feat: Enhance infinite scrolling to use action button for load more data#39792
Merged
jacquesikot merged 13 commits intoreleasefrom Mar 24, 2025
Merged
feat: Enhance infinite scrolling to use action button for load more data#39792jacquesikot merged 13 commits intoreleasefrom
jacquesikot merged 13 commits intoreleasefrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the automatic infinite scrolling behavior in TableWidgetV2 with an explicit "Load More" button. This change improves user experience by:
Changes
Removed Dependencies
react-window-infinite-loaderdependency as it's no longer needed with the new approachKey Implementation Details
Technical Implementation
VirtualList.tsxto include a "Load More" button row when more data is availableuseInfiniteVirtualizationhook to track data availability without automatic loadingInfiniteScrollBodycomponent to pass the necessary props for the load more functionalityFixes #39084
Automation
/ok-to-test tags="@tag.Widget, @tag.Sanity, @tag.Binding"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13971123087
Commit: 42733b8
Cypress dashboard.
Tags:
@tag.Widget, @tag.Sanity, @tag.BindingSpec:
Thu, 20 Mar 2025 15:41:02 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
LoadMoreButtoncomponent for enhanced user interaction when loading more records.Refactor
Tests